Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl(internal/api): create package #339

Merged
merged 2 commits into from
Nov 30, 2024
Merged

impl(internal/api): create package #339

merged 2 commits into from
Nov 30, 2024

Conversation

julieqiu
Copy link
Member

Move the internal API and LanguageCode models to a separate package. This is an intermediary step towards splitting up genclient, and moving the API and Codec models to the same package as the functions that construct them

@julieqiu julieqiu requested a review from coryan November 29, 2024 22:18
@julieqiu julieqiu marked this pull request as draft November 29, 2024 22:19
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits and some comments for the future. I expect you need to make more changes anyway, since the builds are not passing (maybe need to rebase?).

generator/internal/parser/protobuf.go Outdated Show resolved Hide resolved
generator/internal/parser/openapi.go Outdated Show resolved Hide resolved
generator/internal/parser/annotations.go Show resolved Hide resolved
Move the internal API and LanguageCode models to a separate package.
@julieqiu julieqiu marked this pull request as ready for review November 30, 2024 15:54
@julieqiu julieqiu force-pushed the api3 branch 3 times, most recently from e3a7d9a to 7da8581 Compare November 30, 2024 15:58
@julieqiu julieqiu merged commit a9d8055 into googleapis:main Nov 30, 2024
12 checks passed
@julieqiu julieqiu deleted the api3 branch November 30, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants