Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl(internal/language): merge rust and golang into one package #331

Merged
merged 1 commit into from
Nov 29, 2024
Merged

impl(internal/language): merge rust and golang into one package #331

merged 1 commit into from
Nov 29, 2024

Conversation

julieqiu
Copy link
Member

Merge rust and golang to a single language package. This reduces nesting and also makes it easier to share code between these packages in future PRs.

@julieqiu julieqiu marked this pull request as ready for review November 29, 2024 17:00
@julieqiu julieqiu requested a review from coryan November 29, 2024 17:01
coryan
coryan approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can always break this up again if it turns out ${futureLang} requires a separate package or something.

@julieqiu julieqiu merged commit e2d005a into googleapis:main Nov 29, 2024
12 checks passed
@julieqiu julieqiu deleted the p1 branch November 29, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coryan coryan coryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julieqiu @coryan