Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move linters to all_test.go #25

Merged
merged 4 commits into from
Oct 30, 2024
Merged

chore: move linters to all_test.go #25

merged 4 commits into from
Oct 30, 2024

Conversation

julieqiu
Copy link
Member

@julieqiu julieqiu commented Oct 29, 2024

Move linters from .github/workflows/generator.yaml to an all_test.go file, so that they run locally with go test ./...

This should also fix the issue with unparam failing.

@julieqiu
Copy link
Member Author

@coryan - the typos spellchecker seems to be unhappy with go.mod files: https://github.com/googleapis/google-cloud-rust/actions/runs/11584188868/job/32250823401?pr=25

I wonder if we should choose a different one?

@codyoss
Copy link
Member

codyoss commented Oct 30, 2024

After #20 we have a cmd structure. Would you mind moving this under there. Or maybe as a program in an internal folder?

@julieqiu
Copy link
Member Author

julieqiu commented Oct 30, 2024

@codyoss - I was thinking this would run on the whole module (including cmd/), hence putting it in the top-level directory. What do you think?

@codyoss
Copy link
Member

codyoss commented Oct 30, 2024

@codyoss - I was thinking this would run on the whole module (including cmd/), hence putting it in the top-level directory. What do you think?

Just because the code does not live in the root of the project does not mean it can't execute over the whole project. You could manipulate the working directory of the command for instance. The reason I also mentioned internal as well as well is I have liked putting code like this in its own module so it does not pollute the deps(go.mod) of the main thing I actually care about. That part is probably less important in a module like this where the main artifact is a binary and not a library.

generator/all_test.go Outdated Show resolved Hide resolved
@julieqiu julieqiu merged commit b3bdd95 into main Oct 30, 2024
12 checks passed
@julieqiu julieqiu deleted the pr2 branch October 30, 2024 17:11
julieqiu added a commit that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants