-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move linters to all_test.go #25
Conversation
@coryan - the I wonder if we should choose a different one? |
After #20 we have a cmd structure. Would you mind moving this under there. Or maybe as a program in an internal folder? |
@codyoss - I was thinking this would run on the whole module (including |
Just because the code does not live in the root of the project does not mean it can't execute over the whole project. You could manipulate the working directory of the command for instance. The reason I also mentioned internal as well as well is I have liked putting code like this in its own module so it does not pollute the deps(go.mod) of the main thing I actually care about. That part is probably less important in a module like this where the main artifact is a binary and not a library. |
Move linters from
.github/workflows/generator.yaml
to anall_test.go
file, so that they run locally withgo test ./..
.This should also fix the issue with
unparam
failing.