docs(pubsub): Add ingestion from GCS samples #27434
Conversation
product-auto-label
bot
added
api: pubsub
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
|
The test is failing because the GCS ingestion feature is not enabled for the integration test project. It looks like the project is |
michaelpri10
added
the
kokoro:run
michaelpri10
removed
the
kokoro:run
…ngestion sample test
|
The GCS bucket |
|
Gentle bump on this @dazuma |
| let(:subscription_id) { random_subscription_id } | ||
| let(:dead_letter_topic_id) { random_topic_id } | ||
|
|
||
| after do | ||
| @subscription.delete if @subscription | ||
| @topic.delete if @topic | ||
| @cloud_storage_ingestion_topic.delete if @cloud_storage_ingestion_topic |
There was a problem hiding this comment.
I don't see where this instance variable gets set. Did you intend to set it in the test below (i.e. instead of just setting a local variable in line 74)?
| @@ -392,14 +409,14 @@ | |||
|
|
|||
| # Pub/Sub calls may not respond immediately. | |||
| # Wrap expectations that may require multiple attempts with this method. | |||
| def expect_with_retry sample_name, attempts: 5 | |||
| def expect_with_retry(sample_name, attempts: 5) | |||
There was a problem hiding this comment.
You shouldn't need to add these parens. Our style prefers omitting them.
This adds samples for Pub/Sub ingestion from GCS topics.