Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl(bigquery): Json parsing changes for custom BigQuery library #14918

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

jsrinnn
Copy link
Collaborator

@jsrinnn jsrinnn commented Jan 8, 2025

This PR modifies the SafeGetToNullable method based on the calling use case. The Json value field can hold any values and it is best parsed on the calling layer based on column schema and the row data that is provided to the caller.

The function is being modified to consistently return a string value. What that string value means is decided and parsed by by the calling layer as it has the most information to parse the value. It is not feasible to do this parsing at the Client LIbrary layer for our usecase.


This change is Reviewable

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (ae1e1e9) to head (e1e68a4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14918      +/-   ##
==========================================
- Coverage   92.91%   92.91%   -0.01%     
==========================================
  Files        2351     2351              
  Lines      209702   209741      +39     
==========================================
+ Hits       194851   194881      +30     
- Misses      14851    14860       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsrinnn jsrinnn marked this pull request as ready for review January 8, 2025 20:05
@jsrinnn jsrinnn requested a review from a team as a code owner January 8, 2025 20:05
@jsrinnn jsrinnn merged commit c244812 into googleapis:main Jan 9, 2025
73 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants