impl(bigquery): Json parsing changes for custom BigQuery library #14918
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
SafeGetToNullable
method based on the calling use case. The Json value field can hold any values and it is best parsed on the calling layer based on column schema and the row data that is provided to the caller.The function is being modified to consistently return a string value. What that string value means is decided and parsed by by the calling layer as it has the most information to parse the value. It is not feasible to do this parsing at the Client LIbrary layer for our usecase.
This change is