fix: add timeout for auth requests #1616
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -184,6 +185,7 @@ def __call__( | |||
| """ | |||
| try: | |||
| _LOGGER.debug("Making request: %s %s", method, url) | |||
| timeout = timeout if timeout != _DEFAULT_TIMEOUT else self.timeout | |||
There was a problem hiding this comment.
There is an edge case where someone sets t1 at the object level but they want default timeout for a specific request. They have no way of doing that now. Even if default timeout is passed to call explicitly, it is going to use the object level one.
| @@ -137,9 +137,10 @@ class Request(transport.Request): | |||
| .. automethod:: __call__ | |||
| """ | |||
|
|
|||
| def __init__(self, session=None): | |||
There was a problem hiding this comment.
| @@ -137,9 +137,10 @@ class Request(transport.Request): | |||
| .. automethod:: __call__ | |||
| """ | |||
|
|
|||
| def __init__(self, session=None): | |||
There was a problem hiding this comment.
Checkout how AuthorizedSession is handling the timeouts and see if we can adapt same. I see something about TimeGuards there as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expose a parameter in the request constructor to allow the end user to pass in the custom timeout value. Currently _DEFAULT_TIMEOUT is being used, which may not be suitable for all the users