Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a file system cache class #571

Merged
merged 14 commits into from
Aug 22, 2024
Merged
224 changes: 224 additions & 0 deletions src/Cache/FileSystemCacheItemPool.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,224 @@
<?php
/**
* Copyright 2024 Google Inc. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

namespace Google\Auth\Cache;

use ErrorException;
use Exception;
use Psr\Cache\CacheItemInterface;
use Psr\Cache\CacheItemPoolInterface;

class FileSystemCacheItemPool implements CacheItemPoolInterface
{
/**
* @var string
*/
private string $cachePath = 'cache/';
Hectorhammett marked this conversation as resolved.
Show resolved Hide resolved

/**
* @var array<CacheItemInterface>
*/
private array $buffer = [];

/**
* Creates a FileSystemCacheItemPool cache that stores values in local storage
*
* @param string $path The string representation of the path where the cache will store the serialized objects.
*/
public function __construct(string $path)
{
$this->cachePath = $path;

if (is_dir($this->cachePath)) {
return;
}

if (!mkdir($this->cachePath)) {
throw new ErrorException("Cache folder couldn't be created.");
}
}

/**
* {@inheritdoc}
*/
public function getItem(string $key): CacheItemInterface
{
if (!$this->validKey($key)) {
throw new InvalidArgumentException("The key '$key' is not valid. The key should follow the pattern |^[a-zA-Z0-9_\.! ]+$|");
}

$itemPath = $this->cacheFilePath($key);

if (!file_exists($itemPath)) {
return new TypedItem($key);
}

$serializedItem = file_get_contents($itemPath);

if ($serializedItem === false) {
return new TypedItem($key);
}

return unserialize($serializedItem);
}

/**
* {@inheritdoc}
*
* @return iterable<CacheItemInterface> An iterable object containing all the
* A traversable collection of Cache Items keyed by the cache keys of
* each item. A Cache item will be returned for each key, even if that
* key is not found. However, if no keys are specified then an empty
* traversable MUST be returned instead.
*/
public function getItems(array $keys = []): iterable
{
$result = [];

foreach ($keys as $key) {
$result[$key] = $this->getItem($key);
}

return $result;
}

/**
* {@inheritdoc}
*/
public function save(CacheItemInterface $item): bool
{
if (!$this->validKey($item->getKey())) {
throw new InvalidArgumentException('The key ' . $item->getKey() . " is not valid. The key should follow the pattern |^[a-zA-Z0-9_\.! ]+$|");
}

$itemPath = $this->cacheFilePath($item->getKey());
$serializedItem = serialize($item);
Hectorhammett marked this conversation as resolved.
Show resolved Hide resolved

$result = file_put_contents($itemPath, $serializedItem);

if (!$result) {
return false;
}

return true;
Hectorhammett marked this conversation as resolved.
Show resolved Hide resolved
}

/**
* {@inheritdoc}
*/
public function hasItem(string $key): bool
{
return $this->getItem($key)->isHit();
}

/**
* {@inheritdoc}
*/
public function clear(): bool
{
if (!is_dir($this->cachePath)) {
return false;
}

$files = scandir($this->cachePath);
if (!$files) {
return false;
}
Hectorhammett marked this conversation as resolved.
Show resolved Hide resolved

foreach($files as $fileName) {
Hectorhammett marked this conversation as resolved.
Show resolved Hide resolved
if ($fileName === '.' || $fileName === '..') {
continue;
}

if (!unlink($this->cachePath . '/' . $fileName)) {
return false;
}
}

return true;
}

/**
* {@inheritdoc}
*/
public function deleteItem(string $key): bool
{
if (!$this->validKey($key)) {
throw new Exception("The key '$key' is not valid. The key should follow the pattern |^[a-zA-Z0-9_\.! ]+$|");
}

$itemPath = $this->cacheFilePath($key);

if (!file_exists($itemPath)) {
return false;
Hectorhammett marked this conversation as resolved.
Show resolved Hide resolved
}

return unlink($itemPath);
}

/**
* {@inheritdoc}
*/
public function deleteItems(array $keys): bool
{
$result = true;

foreach($keys as $key) {
Hectorhammett marked this conversation as resolved.
Show resolved Hide resolved
if (!$this->deleteItem($key)) {
$result = false;
}
}

return $result;
}

/**
* {@inheritdoc}
*/
public function saveDeferred(CacheItemInterface $item): bool
{
array_push($this->buffer, $item);

return true;
}

/**
* {@inheritdoc}
*/
public function commit(): bool
{
$result = true;

foreach ($this->buffer as $item) {
if (!$this->save($item)) {
$result = false;
}
}

return $result;
}

private function cacheFilePath(string $key): string
{
return $this->cachePath . '/' . $key;
}

private function validKey(string $key): bool
{
return (bool)preg_match('|^[a-zA-Z0-9_\.! ]+$|', $key);
}
}
159 changes: 159 additions & 0 deletions tests/Cache/FileSystemCacheItemPoolTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,159 @@
<?php
/*
* Copyright 2024 Google Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

namespace Google\Auth\Tests\Cache;

use Google\Auth\Cache\FileSystemCacheItemPool;
use Google\Auth\Cache\TypedItem;
use PHPUnit\Framework\TestCase;
use Psr\Cache\CacheItemInterface;

class FileSystemCacheItemPoolTest extends TestCase
{
private string $defaultCacheDirectory = 'cache/';
Hectorhammett marked this conversation as resolved.
Show resolved Hide resolved
private FileSystemCacheItemPool $pool;

public function setUp(): void
{
$this->pool = new FileSystemCacheItemPool($this->defaultCacheDirectory);
}

public function tearDown(): void
{
$files = scandir($this->defaultCacheDirectory);

foreach($files as $fileName) {
if ($fileName === '.' || $fileName === '..') {
continue;
}

unlink($this->defaultCacheDirectory . '/' . $fileName);
}

rmdir($this->defaultCacheDirectory);
}

public function testInstanceCreatesCacheFolder()
{
$this->assertTrue(file_exists($this->defaultCacheDirectory));
$this->assertTrue(is_dir($this->defaultCacheDirectory));
}

public function testSaveAndGetItem()
{
$item = $this->getNewItem();
$this->pool->save($item);
$retrievedItem = $this->pool->getItem($item->getKey());

$this->assertTrue($retrievedItem->isHit());
$this->assertEquals($retrievedItem->get(), $item->get());
}

public function testHasItem()
{
$item = $this->getNewItem();
$this->assertFalse($this->pool->hasItem($item->getKey()));
$this->pool->save($item);
$this->assertTrue($this->pool->hasItem($item->getKey()));
}

public function testDeleteItem()
{
$item = $this->getNewItem();
$this->pool->save($item);

$this->assertTrue($this->pool->deleteItem($item->getKey()));
$this->assertFalse($this->pool->hasItem($item->getKey()));
}

public function testDeleteItems()
{
$items = [
$this->getNewItem(),
$this->getNewItem('NewItem2'),
$this->getNewItem('NewItem3')
];

foreach ($items as $item) {
$this->pool->save($item);
}

$itemKeys = array_map(function (CacheItemInterface $item) {
return $item->getKey();
}, $items);
Hectorhammett marked this conversation as resolved.
Show resolved Hide resolved

$result = $this->pool->deleteItems($itemKeys);
$this->assertTrue($result);

$result = $this->pool->deleteItems($itemKeys);
$this->assertFalse($result);
}

public function testGetItems()
{
$items = [
$this->getNewItem(),
$this->getNewItem('NewItem2'),
$this->getNewItem('NewItem3')
];

foreach ($items as $item) {
$this->pool->save($item);
}

$keys = array_map(function (CacheItemInterface $item) {
return $item->getKey();
}, $items);
Hectorhammett marked this conversation as resolved.
Show resolved Hide resolved
array_push($keys, 'NonExistant');

$retrievedItems = $this->pool->getItems($keys);

foreach ($items as $item) {
$this->assertTrue($retrievedItems[$item->getKey()]->isHit());
}

$this->assertFalse($retrievedItems['NonExistant']->isHit());
}

public function testClear()
{
$item = $this->getNewItem();
$this->pool->save($item);
$this->assertLessThan(scandir($this->defaultCacheDirectory), 2);
$this->pool->clear();
// Clear removes all the files, but scandir returns `.` and `..` as files
$this->assertEquals(count(scandir($this->defaultCacheDirectory)), 2);
}

public function testSaveDeferredAndCommit()
{
$item = $this->getNewItem();
$this->pool->saveDeferred($item);
$this->assertFalse($this->pool->getItem($item->getKey())->isHit());

$this->pool->commit();
$this->assertTrue($this->pool->getItem($item->getKey())->isHit());
}

private function getNewItem(null|string $key = null): TypedItem
{
$item = new TypedItem($key ?? 'NewItem');
$item->set('NewValue');

return $item;
}
}