Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws_auth): Add support of awsSecurityCredentialsSupplierClass in ExternalAccountCredentials when create from GcpCredentials from file. #1540

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GrigorievNick
Copy link

Add support of awsSecurityCredentialsSupplierClass in ExternalAccountCredentials when creating GcpCredentials from the file.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way, we can discuss the change, evaluate designs, and agree on the general idea
  • [] Ensure the tests and linter pass
  • [] Code coverage does not decrease (if any source code was changed)
  • [] Appropriate docs were updated (if necessary)

Fixes #1408

If you write sample code, please follow the samples format.

@GrigorievNick GrigorievNick requested review from a team as code owners October 17, 2024 14:10
Copy link

conventional-commit-lint-gcf bot commented Oct 17, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 17, 2024
@GrigorievNick GrigorievNick changed the title Add support of awsSecurityCredentialsSupplierClass in ExternalAccount… Add support of awsSecurityCredentialsSupplierClass in ExternalAccountCredentials when creating GcpCredentials from the file. Oct 17, 2024
@GrigorievNick GrigorievNick changed the title Add support of awsSecurityCredentialsSupplierClass in ExternalAccountCredentials when creating GcpCredentials from the file. 1408: Add support of awsSecurityCredentialsSupplierClass in ExternalAccountCredentials when creating GcpCredentials from the file. Oct 17, 2024
@GrigorievNick GrigorievNick force-pushed the plugable-AwsSecurityCredentialSuplier branch 2 times, most recently from fcedfdd to 5f645e7 Compare October 17, 2024 14:19
@GrigorievNick GrigorievNick changed the title 1408: Add support of awsSecurityCredentialsSupplierClass in ExternalAccountCredentials when creating GcpCredentials from the file. feat: Add support of awsSecurityCredentialsSupplierClass in ExternalAccountCredentials when creating GcpCredentials from the file. Oct 17, 2024
… ExternalAccountCredentials when create from GcpCredentials from file.
@GrigorievNick GrigorievNick force-pushed the plugable-AwsSecurityCredentialSuplier branch from 5f645e7 to e1e41de Compare October 17, 2024 14:22
@GrigorievNick GrigorievNick changed the title feat: Add support of awsSecurityCredentialsSupplierClass in ExternalAccountCredentials when creating GcpCredentials from the file. feat(aws_auth): Add support of awsSecurityCredentialsSupplierClass in ExternalAccountCredentials when create from GcpCredentials from file. Oct 17, 2024
@GrigorievNick
Copy link
Author

@googleapis-stewards, how can I get any feedback?

@lqiu96
Copy link
Contributor

lqiu96 commented Dec 12, 2024

@lsirac @googleapis/aion-sdk I think this change would be better to be reviewed by you all. If you feel otherwise, I can take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants