Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadBannerAd looping because of autoRefresh #206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FujiKinaga
Copy link

@FujiKinaga FujiKinaga commented Dec 3, 2019

Will be called onAdLoaded() or onAdFailedToLoad(int errorCode) of AdListener when AdMob's autoRefresh do.
So I guess that we should make AdListener into null on first callback.

Current

スクリーンショット 2019-12-03 14 56 57

Improved

スクリーンショット 2019-12-03 14 55 01

I want to know whether we should refresh all adList or only visible ad when auto refreshing any ad.
Or do you have some better solutions? ex. On RecyclerView's viewHolder.onBindViewHolder, start loading and prefetch next indexed ad. (my sample)

Could you please give me some feedbacks!🙇‍♂️

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@FujiKinaga
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants