Rename get product category constants #474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ibe38e3a124318893ca4917e388c0ed9cf73a4f06
Change-Id: I17867fc4eae63c6e7b36f4f2720b322df65583da
mcloonan
requested changes
Jan 12, 2024
| # values. This is an example to override a recommended ad when a | ||
| # TextAdRecommendation is applied. | ||
| # For details, please read | ||
| # https://developers.google.com/google-ads/api/reference/rpc/google.ads.google_ads.v1.services#google.ads.google_ads.v1.services.ApplyRecommendationOperation |
| @@ -70,10 +70,46 @@ def detect_and_apply_recommendations(customer_id) | |||
| end | |||
| end | |||
|
|
|||
| # [START apply_recommendation] | |||
| def apply_recommendation(client, customer_id, recommendation_resource) | |||
| # If you have a recommendation_id instead of the resournce_name | |||
| @@ -33,34 +33,34 @@ def detect_and_apply_recommendations(customer_id) | |||
| client = Google::Ads::GoogleAds::GoogleAdsClient.new | |||
|
|
|||
| query = <<~QUERY | |||
| SELECT recommendation.resource_name | |||
| SELECT recommendation.resource_name, recommendation.campaign, | |||
| recommendation.keyword_recommendation | |||
There was a problem hiding this comment.
Can we put one field per line?
| end | ||
|
|
||
| apply_recommendation(client, customer_id, recommendation.resource_name) | ||
| end | ||
|
|
||
| if i < NUMBER_OF_RUNS - 1 |
There was a problem hiding this comment.
Why does this still exist if we're reducing the number of runs to 1?
There was a problem hiding this comment.
Sorry, ignore this changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.