[dslx_fmt] Support multiple arguments as input, similar to other formatters #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dplassgit
reviewed
Jan 24, 2025
| bool has_stdin_arg = | ||
| std::any_of(input_paths.begin(), input_paths.end(), | ||
| [](std::string_view path) { return path == "-"; }); | ||
| if (has_stdin_arg) { |
There was a problem hiding this comment.
Thoughts on adding tests for each of these cases?
There was a problem hiding this comment.
I think I've got testing in the .py for the interesting modes and combinations now -- LMK if you see any more that seem like they're missing!
cdleary
force-pushed
the
cdleary/2025-01-24-dslx-fmt-multi-arg
branch
2 times, most recently
from
5a04009 to
1f0a127
Compare
cdleary
force-pushed
the
cdleary/2025-01-24-dslx-fmt-multi-arg
branch
from
1f0a127 to
f44822f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us slot into a pre-commit hook more easily, looks like it batches up about 8 files at a time by default to avoid too many subprocess invocations.