Added a default case to HttpStatus to handle invalid HTTP status better.

PiperOrigin-RevId: 464635818
Change-Id: Iec3bbf9b4199c766cc9eeae1d723d9c5376a1a95

common/src/main/java/com/google/tsunami/common/net/http/HttpStatus.java

@@ -20,7 +20,6 @@
 import com.google.common.collect.ImmutableMap;
 import java.util.Arrays;
 import java.util.function.Function;
-import javax.annotation.Nullable;
 
 /**
  * HTTP Status Codes defined in RFC 2616, RFC 6585, RFC 4918 and RFC 7538.
@@ -35,6 +34,8 @@
  *     target="_top">https://tools.ietf.org/html/rfc7538</a>
  */
 public enum HttpStatus {
+  // Default
+  HTTP_STATUS_UNSPECIFIED(0, "Status Unspecified"),
 
   // Informational 1xx
   CONTINUE(100, "Continue"),
@@ -115,9 +116,9 @@ public enum HttpStatus {
    * @param code the HTTP status code.
    * @return the matching {@link HttpStatus} from the given status code.
    */
-  @Nullable
   public static HttpStatus fromCode(int code) {
-    return BY_CODE.get(code);
+    HttpStatus status = BY_CODE.get(code);
+    return status == null ? HTTP_STATUS_UNSPECIFIED : status;
   }
 
   private final int code;

common/src/test/java/com/google/tsunami/common/net/http/HttpResponseTest.java

@@ -134,4 +134,16 @@ public void jsonFieldEqualsToValue_whenJsonFieldContainsValue_returnsTrue() {
 
     assertTrue(httpResponse.jsonFieldEqualsToValue("field", "value"));
   }
+
+  @Test
+  public void bodyJson_whenHttpStatusInvalid_parseSucceeds() {
+    HttpResponse httpResponse =
+        HttpResponse.builder()
+            .setStatus(HttpStatus.HTTP_STATUS_UNSPECIFIED)
+            .setHeaders(HttpHeaders.builder().build())
+            .setResponseUrl(TEST_URL)
+            .build();
+
+    assertFalse(httpResponse.status().isSuccess());
+  }
 }