Enhancement/9285 internal server error refactor #10100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for d73e742 are ready:
|
|
Size Change: -555 B (-0.03%) Total Size: 1.99 MB
ℹ️ View Unchanged
|
|
JS tests are flaky, nothing related to this PR |
jimmymadon
requested changes
Jan 22, 2025
There was a problem hiding this comment.
Hey @zutigrm, thanks for this PR! I've added a couple of comments. But also, when I follow the QAB, the notification doesn't appear automatically, like it does on the develop branch. I've had to run await googlesitekit.data.select('core/notifications').getQueuedNotifications('settings'); in the console for the error to appear on the Settings page after making a request with a 500 error. I used tweak and followed your QAB exactly.
I think we are again having a use case where we need to have an 'ad hoc' notification added to the queue.
InternalServerError.mov
| @@ -24,14 +24,12 @@ import { Fragment } from '@wordpress/element'; | |||
| /** | |||
| * Internal dependencies | |||
| */ | |||
| import InternalServerError from './InternalServerError'; | |||
| import Notifications from './Notifications'; | |||
| import { NOTIFICATION_AREAS } from '../../googlesitekit/notifications/datastore/constants'; | |||
|
|
|||
| export default function ErrorNotifications() { | |||
| return ( | |||
| <Fragment> | |||
There was a problem hiding this comment.
No need for the <Fragment> now.
| // The activateModule() action which is used to forward the errors | ||
| // to the `internalServerError` state value uses internally | ||
| // getAuthentication() resolver. | ||
| await resolveSelect( CORE_USER ).getAuthentication(); |
There was a problem hiding this comment.
The activateModule action which eventually does setModuleActivation action calls REFETCH_AUTHENTICATION only on success. So I don't think this will make any difference here. Am I missing something here?
There was a problem hiding this comment.
Indeed, it slipped my mind that this notification is shown on failure, so this won't be needed
…nternal-server-error-refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist