-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add synchronization of RRM publication information #10087
Conversation
Build files for 2baac2b have been deleted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work on this, @ankitrox! This looks really promising.
This works and looks good, however, I've left a number of comments that aims to improve the implementation, mostly in terms of simplicity and readability.
As you are off sick, I've gone ahead and applied the changes myself. The changes also include some minor nitpicky grammatical and cosmetic changes, mostly to docblock comments. Kindly take a look to see if you have any questions or concerns.
Thanks!
includes/Modules/Reader_Revenue_Manager/Synchronize_Publication.php
Outdated
Show resolved
Hide resolved
includes/Modules/Reader_Revenue_Manager/Synchronize_Publication.php
Outdated
Show resolved
Hide resolved
includes/Modules/Reader_Revenue_Manager/Synchronize_Publication.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @ankitrox !
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist