Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte weak credentials #88

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

secureness
Copy link
Contributor

@secureness secureness commented Sep 13, 2024

@RaulDoyensec
Copy link

RaulDoyensec commented Oct 15, 2024

Hi @secureness,

Thank you for your contribution:

  • I noticed that port 2375 is being exposed, which is the host’s Docker socket. This can potentially compromise the host.
  • Additionally, there are many variables referenced in the docker-compose.yaml file that are not set, which makes the configuration non-functional.
  • For the safe configuration, it would be helpful if you could also provide a working docker-compose file that avoids the need to install additional software manually.

Regards.

@RaulDoyensec
Copy link

Hi @secureness

I just wanted to follow up on the changes I suggested for your PR. Let me know if you have any questions or need further clarification.

Regards

@secureness
Copy link
Contributor Author

@RaulDoyensec Hi, sorry I forgot about this PR, thanks for reminding me :))
I'm going to solve the issue today.

@secureness
Copy link
Contributor Author

@RaulDoyensec Sadly the docker-compose setup is deprecated and it doesn't work anymore, I tried to patch the docker-compose configuration but it wasn't possible.
for now, I choose the easiest setup which we only need to download an executable in the current directory and also install the docker and minikube. this can be a most clean setup so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants