Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kernelCTF CVE-2023-6817_lts_cos #90

Merged
merged 9 commits into from
Jul 29, 2024
Merged

Conversation

conlonial
Copy link
Contributor

No description provided.

Copy link

@matrizzo matrizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I left a few comments on the writeup. I would prefer if this was self-contained instead of having to reference the other writeup to understand what's going on because that makes it hard to read.

Also, there is a lot of code that has been commented out. If it's not used then please remove it.

@matrizzo
Copy link

There are still a few comments that haven't been addressed yet (for example #90 (comment)).

@conlonial
Copy link
Contributor Author

There are still a few comments that haven't been addressed yet (for example #90 (comment)).

@conlonial conlonial closed this Jul 24, 2024
@conlonial conlonial reopened this Jul 24, 2024
@conlonial
Copy link
Contributor Author

There are still a few comments that haven't been addressed yet (for example #90 (comment)).

Hi, all the comments has been handled. Please check it.

@matrizzo
Copy link

There are still some unaddressed comments. The GitHub UI might hide some of them my default and you might have to click "load more" to see them.

@conlonial
Copy link
Contributor Author

There are still some unaddressed comments. The GitHub UI might hide some of them my default and you might have to click "load more" to see them.

Oh, Sorry about that. I should have dealt with all the comments this time.

Copy link
Collaborator

@koczkatamas koczkatamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! I've checked the previous review comments and everything seems to be corrected (thanks!) except that the exploitation steps indeed seems not to be in sync with the writeup and/or missing. I made comments about all the places I am missing something or where I feel it is incorrect.

Please make a last change fixing those and then I will merge the CL. Thanks again and sorry for the long process.

@koczkatamas koczkatamas merged commit 0226d51 into google:master Jul 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants