-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding code to support optional type abbreviation request #380
base: master
Are you sure you want to change the base?
Conversation
@googlebot Could you please submit a rescan for the CLA? Thanks! |
2d4c679
to
e6b2d8e
Compare
PiperOrigin-RevId: 379999792 Change-Id: I2594db4540cfe20820951bae479d16c167ba391a adding code to support optional type appreviation request Author: Damien Burks <[email protected]> committing latest changes for supporting python 3.9+
e6b2d8e
to
b1d4e45
Compare
Signed-off-by: Damien Burks <[email protected]>
Added that adjustment. I wasn't aware that Union could have more than 2 options, so that you for the recommendation @genos |
Thanks for the contribution! This looks good. |
@dbieber it supports python versions 3.x and up. I have not tested this with any of the python 2 versions. Let me know if this is an issue. |
We don't need the improvement to apply to Python 2, but we do need to make sure we don't break fire for Python 2.7. |
@dbieber I will check into this, and attach my results to this issue. Thanks. |
Addresses #329