Skip to content

Commit

Permalink
Add the isOwned property to shareInfo.
Browse files Browse the repository at this point in the history
Change-Id: I9560a4a0369eeeae3f400f219697db7183a3f7ff
  • Loading branch information
laurenmanzo committed Aug 13, 2019
1 parent b1b9437 commit 9d231be
Show file tree
Hide file tree
Showing 7 changed files with 340 additions and 278 deletions.
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
}
},
"require": {
"google/gax": "^0.37.0",
"google/protobuf": "^3.5.1",
"google/gax": "^1.0.2",
"google/protobuf": "^3.7.1",
"php" : "^5.5 || ^7.0"
},
"require-dev": {
Expand Down
531 changes: 272 additions & 259 deletions src/GPBMetadata/Google/Photos/Library/V1/PhotosLibrary.php

Large diffs are not rendered by default.

19 changes: 10 additions & 9 deletions src/GPBMetadata/Google/Photos/Types/Album.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,9 @@ public function createAlbum($album, array $optionalArgs = [])
* <a href="/photos/library/guides/upload-media">Uploading media</a>.
*
* This call adds the media item to the library. If an album `id` is
* specified, the call adds the media item to the album too. By default, the
* media item will be added to the end of the library or album.
* specified, the call adds the media item to the album too. Each album can
* contain up to 20,000 media items. By default, the media item will be added
* to the end of the library or album.
*
* If an album `id` and position are both defined, the media item is
* added to the album at the specified position.
Expand Down Expand Up @@ -335,6 +336,8 @@ public function batchCreateMediaItems($newMediaItems, array $optionalArgs = [])
* Media items are added to the end of the album. If multiple media items are
* given, they are added in the order specified in this call.
*
* Each album can contain up to 20,000 media items.
*
* Only media items that are in the user's library can be added to an
* album. For albums that are shared, the album must either be owned by the
* user or the user must have joined the album as a collaborator.
Expand Down
7 changes: 5 additions & 2 deletions src/Google/Photos/Library/V1/PhotosLibraryGrpcClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,9 @@ public function CreateAlbum(\Google\Photos\Library\V1\CreateAlbumRequest $argume
* <a href="/photos/library/guides/upload-media">Uploading media</a>.
*
* This call adds the media item to the library. If an album `id` is
* specified, the call adds the media item to the album too. By default, the
* media item will be added to the end of the library or album.
* specified, the call adds the media item to the album too. Each album can
* contain up to 20,000 media items. By default, the media item will be added
* to the end of the library or album.
*
* If an album `id` and position are both defined, the media item is
* added to the album at the specified position.
Expand Down Expand Up @@ -93,6 +94,8 @@ public function BatchCreateMediaItems(\Google\Photos\Library\V1\BatchCreateMedia
* Media items are added to the end of the album. If multiple media items are
* given, they are added in the order specified in this call.
*
* Each album can contain up to 20,000 media items.
*
* Only media items that are in the user's library can be added to an
* album. For albums that are shared, the album must either be owned by the
* user or the user must have joined the album as a collaborator.
Expand Down
34 changes: 34 additions & 0 deletions src/Google/Photos/Types/ShareInfo.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 12 additions & 4 deletions tests/Unit/V1/PhotosLibraryClientTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
use stdClass;

/**
* @group photoslibrary
* @group library
* @group gapic
*/
class PhotosLibraryClientTest extends GeneratedTest
Expand All @@ -62,15 +62,23 @@ private function createTransport($deserialize = null)
return new MockTransport($deserialize);
}

/**
* @return CredentialsWrapper
*/
private function createCredentials()
{
return $this->getMockBuilder(CredentialsWrapper::class)
->disableOriginalConstructor()
->getMock();
}

/**
* @return PhotosLibraryClient
*/
private function createClient(array $options = [])
{
$options += [
'credentials' => $this->getMockBuilder(CredentialsWrapper::class)
->disableOriginalConstructor()
->getMock(),
'credentials' => $this->createCredentials(),
];

return new PhotosLibraryClient($options);
Expand Down

0 comments on commit 9d231be

Please sign in to comment.