Add flags to run_all.py for customizing test timeout and subdirectory traversal behavior #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable passing a custom timeout value to run_all.py. If unspecified, the default remains 180. Tested: on kernel netdev-netnext/master HEAD at commit 5e437416ff669 (1) verify default timeout remains 180: $ python ./packetdrill/run_all.py -S -v -L -l tcp/mss/mss-getsockopt-tcp_maxseg-server.pkt OK [/export/hda3/tmp/tannerlove/net/tcp/mss/mss-getsockopt-tcp_maxseg-server.pkt (ipv4)] stdout: stderr: OK [/export/hda3/tmp/tannerlove/net/tcp/mss/mss-getsockopt-tcp_maxseg-server.pkt (ipv6)] stdout: stderr: OK [/export/hda3/tmp/tannerlove/net/tcp/mss/mss-getsockopt-tcp_maxseg-server.pkt (ipv4-mapped-v6)] stdout: stderr: Ran 3 tests: 3 passing, 0 failing, 0 timed out (3.83 sec): tcp/mss/mss-getsockopt-tcp_maxseg-server.pkt (2) verify -t 0 results in timeout: python ./packetdrill/run_all.py -S -v -L -l -t 0 tcp/mss/mss-getsockopt-tcp_maxseg-server.pkt KILL [/export/hda3/tmp/tannerlove/net/tcp/mss/mss-getsockopt-tcp_maxseg-server.pkt (ipv4)] stdout: stderr: KILL [/export/hda3/tmp/tannerlove/net/tcp/mss/mss-getsockopt-tcp_maxseg-server.pkt (ipv4-mapped-v6)] stdout: stderr: KILL [/export/hda3/tmp/tannerlove/net/tcp/mss/mss-getsockopt-tcp_maxseg-server.pkt (ipv6)] stdout: stderr: Ran 3 tests: 0 passing, 0 failing, 3 timed out (1.85 sec): tcp/mss/mss-getsockopt-tcp_maxseg-server.pkt Signed-off-by: Tanner Love <[email protected]>
When flag is specified, run_all.py does not look for .pkt files in subdirectories of the specified directory. Tested: (on kernel netdev-netnext/master HEAD at commit 5e437416ff669) Currently there are no existing cases where we have both a foo/bar.pkt and a foo/baz/buz.pkt. To simulate this likely future scenario, I did: (0) setup: duplicate a test in a parent dir $ cp gtests/net/tcp/fastopen/server/client-ack-dropped-then-recovery-ms-timestamps.pkt \ gtests/net/tcp/fastopen/client-ack-dropped-then-recovery-ms-timestamps.pkt (1) verify that subdirs are traversed when flag is not specified $ python ./packetdrill/run_all.py -S -v -L -l tcp/fastopen OK [/export/hda3/tmp/tannerlove/net/tcp/fastopen/client-ack-dropped-then-recovery-ms-timestamps.pkt (ipv4)] stdout: stderr: OK [/export/hda3/tmp/tannerlove/net/tcp/fastopen/client-ack-dropped-then-recovery-ms-timestamps.pkt (ipv6)] stdout: stderr: OK [/export/hda3/tmp/tannerlove/net/tcp/fastopen/server/client-ack-dropped-then-recovery-ms-timestamps.pkt (ipv4-mapped-v6)] stdout: stderr: OK [/export/hda3/tmp/tannerlove/net/tcp/fastopen/client-ack-dropped-then-recovery-ms-timestamps.pkt (ipv4-mapped-v6)] stdout: stderr: OK [/export/hda3/tmp/tannerlove/net/tcp/fastopen/server/client-ack-dropped-then-recovery-ms-timestamps.pkt (ipv6)] stdout: stderr: OK [/export/hda3/tmp/tannerlove/net/tcp/fastopen/server/client-ack-dropped-then-recovery-ms-timestamps.pkt (ipv4)] stdout: stderr: Ran 6 tests: 6 passing, 0 failing, 0 timed out (4.32 sec): tcp/fastopen (2) verify that subdirs are not traversed when flag is specified $ python ./packetdrill/run_all.py -S -v -L -l --no-traverse_subdirs tcp/fastopen OK [/export/hda3/tmp/tannerlove/net/tcp/fastopen/client-ack-dropped-then-recovery-ms-timestamps.pkt (ipv4)] stdout: stderr: OK [/export/hda3/tmp/tannerlove/net/tcp/fastopen/client-ack-dropped-then-recovery-ms-timestamps.pkt (ipv6)] stdout: stderr: OK [/export/hda3/tmp/tannerlove/net/tcp/fastopen/client-ack-dropped-then-recovery-ms-timestamps.pkt (ipv4-mapped-v6)] stdout: stderr: Ran 3 tests: 3 passing, 0 failing, 0 timed out (2.64 sec): tcp/fastopen Signed-off-by: Tanner Love <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.