-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packetdrill: run_all: pass netmask to remote_ip arg #48
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Makes no difference for upstream packetdrill, but this makes the mptcp-fork 'join' tests work when run from the run_all script. The mp_join tests add a secondary ip address. Without the netmask the kernel can't find a route for the syn/ack packet and the tcp syn carrying the join request never gets a response. The netmasks are the ones used in the two DEFAULT_V{4,6}_LIVE_REMOTE_IP_STRING defines. The basic-v{4,6} test cases are adjusted to add a host-specific route, rather than attempt to change a (now no longer existing) entry. Signed-off-by: Florian Westphal <[email protected]>
27066a0
to
5332910
Compare
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
fix inbound HMAC for ADD_ADDR with port
Makes no difference for upstream packetdrill, but this makes the
mptcp-fork 'join' tests work when run from the run_all script.
The mp_join tests add a secondary ip address. Without the netmask the kernel can't find a route for the syn/ack packet and the tcp syn carrying the join request never gets a response.
The netmasks are the ones used in the two DEFAULT_V{4,6}_LIVE_REMOTE_IP_STRING defines.
The basic-v{4,6} test cases are adjusted to add a host-specific route rather than attempt to change a
(now no longer existing) entry.