Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packetdrill: run_all: pass netmask to remote_ip arg #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fw-strlen
Copy link

Makes no difference for upstream packetdrill, but this makes the
mptcp-fork 'join' tests work when run from the run_all script.

The mp_join tests add a secondary ip address. Without the netmask the kernel can't find a route for the syn/ack packet and the tcp syn carrying the join request never gets a response.

The netmasks are the ones used in the two DEFAULT_V{4,6}_LIVE_REMOTE_IP_STRING defines.

The basic-v{4,6} test cases are adjusted to add a host-specific route rather than attempt to change a
(now no longer existing) entry.

@google-cla
Copy link

google-cla bot commented Dec 1, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Makes no difference for upstream packetdrill, but this makes the
mptcp-fork 'join' tests work when run from the run_all script.

The mp_join tests add a secondary ip address.  Without the netmask
the kernel can't find a route for the syn/ack packet and the tcp syn
carrying the join request never gets a response.

The netmasks are the ones used in the two
DEFAULT_V{4,6}_LIVE_REMOTE_IP_STRING defines.

The basic-v{4,6} test cases are adjusted to add a host-specific
route, rather than attempt to change a (now no longer existing) entry.

Signed-off-by: Florian Westphal <[email protected]>
@google-cla
Copy link

google-cla bot commented Dec 2, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@fw-strlen
Copy link
Author

@googlebot I signed it!

dcaratti added a commit to dcaratti/packetdrill that referenced this pull request Mar 25, 2021
fix inbound HMAC for ADD_ADDR with port
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant