Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for set comments #290

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Add support for set comments #290

merged 1 commit into from
Dec 19, 2024

Conversation

turekt
Copy link
Contributor

@turekt turekt commented Dec 18, 2024

Per issue #288, I've added a simple change to sets to support adding comments.

@turekt turekt mentioned this pull request Dec 18, 2024
@stapelberg
Copy link
Collaborator

Thanks for the PR!

But, your new test seems to fail, at least on GitHub Actions:

--- FAIL: TestSetComment (0.00s)
    nftables_test.go:5954: message 3: got -- want
          01 00 00 00 -- 01 00 00 00
          0b 00 01 00 -- 0b 00 01 00
          66 69 6c 74 -- 66 69 6c 74
          65 72 00 00 -- 65 72 00 00
          0c 00 02 00 -- 0c 00 02 00
          73 65 74 6e -- 73 65 74 6e
          61 6d 65 00 -- 61 6d 65 00
          08 00 03 00 -- 08 00 03 00
          00 00 00 00 -- 00 00 00 00
          08 00 04 00 -- 08 00 04 00
          00 00 00 07 -- 00 00 00 07
          08 00 05 00 -- 08 00 05 00
          00 00 00 04 -- 00 00 00 04
          08 00 0a 00 -- 08 00 0a 00
        ! 00 00 00 02 -- 00 00 00 12
          13 00 0d 00 -- 13 00 0d 00
          07 0d 74 65 -- 07 0d 74 65
          73 74 20 63 -- 73 74 20 63
          6f 6d 6d 65 -- 6f 6d 6d 65
          6e 74 00 00 -- 6e 74 00 00
           -- 
FAIL

Can you take a look please?

@turekt
Copy link
Contributor Author

turekt commented Dec 19, 2024

Set ID may vary per system so its value is now fixed. Should be resolved.

@stapelberg stapelberg merged commit e99829f into google:main Dec 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants