NAT: prefix test #252
Closed
NAT: prefix test #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stapelberg
requested changes
Jan 6, 2024
cheina97
force-pushed
the
frc/natprefix
branch
5 times, most recently
from
7c8c73a to
ae1b9c8
Compare
|
Hi @stapelberg, I've left a commit with the fixes you asked for. |
cheina97
force-pushed
the
frc/natprefix
branch
from
ae1b9c8 to
3f57b17
Compare
|
Thanks! Merged as commit 33ee8df with slight adjustments in naming/documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for PR #251
In particular it adds a unit test for this rule
nft add rule nat prerouting ip daddr 10.0.0.0/24 dnat prefix to 20.0.0.0/24The PR includes some utilities to get the first and last IP of a subnet (they include unit tests)