Implement set KeyByteOrder #226
Merged
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes google#225 Introduced KeyByteOrder in sets which fills UDATA with endianess information
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR reverts PR #180 and introduces
KeyByteOrderfield to sets to allow lib users to specify key byte order. PR #180 was a change that introduced a default userdata TLV that specifies key endianess and was implemented to fix issue #177 and conform to main nftables C implementation. This obviously broke setting IPs to sets and there is no other way for users to specify which byte order should be used. Therefore, this change now allows specifying key byte order and should be backwards compatible since not specifyingKeyByteOrderwill marshal bytes as it would prior to PR #180.With this, issue #225 should be fixed. Issue #177 remains, but can now be fixed by specifying
s.KeyByteOrder = binaryutil.NativeEndian.Let me know what you think.