-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color legend in the layer-bar #693
Open
aranega
wants to merge
42
commits into
google:master
Choose a base branch
from
MetaCell:feature/CC-127
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
6c2d3e6
CC-127 Add first PoC about changing layer's title background color
aranega 5dfafe8
Add first version of layer color widget
aranega 6de87f1
Add first color widget in left layer bar
aranega 4b79ce7
Add indicator to express that color is not visible even if active
aranega 110b99b
Fix disposer logic for layer color computation
aranega 9ea3b1e
Add support for color indicator for annotation layer
aranega 149d030
Fix format
aranega 4f8a477
Add color sync setting in layer state
aranega a3a2365
Add single color sync when only 1 label is visible in segmentation layer
aranega 61a6c86
Fix color legend widget sync accross layerbar and layer panel
aranega ff96fd4
CC-167 update rainbow circle
Aiga115 f2e2111
Merge branch 'feature/CC-127' into feature/CC-167
Aiga115 f9cae7f
CC-167 reduce blur on rainbow circle
Aiga115 2229c8f
CC-167 update ui of circle labels
Aiga115 d5f9c52
Merge pull request #58 from MetaCell/feature/CC-167
aranega 9d66b66
Fix rainbow color not removing when number of visible segment changes
aranega f33816a
Move color widget to the left of the title in layer bar
aranega 340be26
Add general option for enabling/disabling color widget
aranega 5aab0c4
Remove unused trackable boolean for color sync inside a layer
aranega 91dbfba
Fix format
aranega 83cde4f
Add layer bar color change on color seed change
aranega 46c78e8
Refactor color widget in layer bar
aranega bddd998
Fix issue with color widget not updated when activated for the first
aranega 491a15d
Fix unsupported style activation for layer list panel
aranega 5b9fa3f
Merge branch 'master' into feature/CC-127
aranega b413a56
CC-189 make changes to ui of non color state circle
Aiga115 5e22083
Display a rainbow when the default annotation color is not used in the
aranega cd24b91
CC-189 remove comment
Aiga115 c9f8ecf
Change tooltip message for annotation with rainbow
aranega 7ad72ff
Fix layer widget color not updating for annotation
aranega ec248e2
Merge branch 'feature/CC-127' of github.com:MetaCell/neuroglancer int…
aranega 1f873d1
Merge pull request #60 from MetaCell/feature/CC-189
aranega e5fe020
CC-200 initial changes made
Aiga115 50cd9d2
Merge pull request #61 from MetaCell/feature/CC-200
aranega c42c86d
chore: formatting pass
seankmartin b9ed80d
feat: clarify tooltip for non-default color annotations
seankmartin 1857d19
CC-127 Remove grid pattern when the layer type changes
aranega 4fbb7b2
CC-127 Update color widget in the layer list when layer type changes
aranega 66e6d39
CC-127 Add tooltip when the layer doesn't support color widget
aranega 66405e1
CC-127 Remove redundant code for color widget from then layer list
aranega 4520ef2
CC-127 Remove user-defined color for layers
aranega 166ff6f
CC-127 Change setting label from color widget to color legend
aranega File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic isn't quite correct --- segmentDefaultColor is overridden by
segmentStatedColors
. This should callgetBaseObjectColor
.