refactor: Eliminate CancellationToken, use AbortSignal instead #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbms
force-pushed
the
refactor-abort-signal
branch
7 times, most recently
from
794c2c7 to
c2386f8
Compare
CancellationToken was introduced before `AbortSignal` was supported by browsers. This commit also unifies handling of authentication status messages and popup windows. Some features previously supported only for middleauth are now supported for all credential providers: - Display authentication status message in "modal" mode by default - Detecting when authentication popup window is closed - Closing the popup if the user navigates away from the page without completing authentication.
This aligns with native JavaScript class properties and improves compatibility with other transpilers/bundlers, like swc and rspack, like that can have varying behavior when `useDefineForClassFields=false`.
jbms
force-pushed
the
refactor-abort-signal
branch
3 times, most recently
from
7dee8cc to
c408c75
Compare
This avoids the possibility of hangs when requesting a chunk via the Python API that is already in a FAILED state.
jbms
force-pushed
the
refactor-abort-signal
branch
from
c408c75 to
24c5bad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CancellationToken was introduced before
AbortSignalwas supported by browsers.This commit also unifies handling of authentication status messages and popup windows. Some features previously supported only for middleauth are now supported for all credential providers: