Don't consider {...} as duplicate placeholder name

google · Dec 29, 2024 · 899292d · 899292d
1 parent 05aac9d
commit 899292d
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/mug-errorprone/src/main/java/com/google/mu/errorprone/StringFormatArgsCheck.java b/mug-errorprone/src/main/java/com/google/mu/errorprone/StringFormatArgsCheck.java
@@ -306,7 +306,9 @@ private void checkDuplicatePlaceholderNames(
       VisitorState state)
       throws ErrorReport {
     ImmutableListMultimap<String, ExpressionTree> allPlaceholders =
-        BiStream.zip(placeholderVariableNames, args).collect(toImmutableListMultimap());
+        BiStream.zip(placeholderVariableNames, args)
+            .skipKeysIf("..."::equals) // wildcard doesn't count as duplicate name
+            .collect(toImmutableListMultimap());
     for (Map.Entry<String, List<ExpressionTree>> entry :
         Multimaps.asMap(allPlaceholders).entrySet()) {
       List<ExpressionTree> conflicts =

diff --git a/mug-errorprone/src/test/java/com/google/mu/errorprone/StringFormatArgsCheckTest.java b/mug-errorprone/src/test/java/com/google/mu/errorprone/StringFormatArgsCheckTest.java
@@ -2207,6 +2207,22 @@ public void format_duplicatePlaceholderNameWithConflictingValues() {
         .doTest();
   }
 
+  @Test
+  public void to_wildcardDoesNotCountAsDuplicateName() {
+    helper
+        .addSourceLines(
+            "Test.java",
+            "import com.google.mu.util.StringFormat;",
+            "class Test {",
+            "  private static final StringFormat.Template<IllegalArgumentException> TEMPLATE =",
+            "      StringFormat.to(IllegalArgumentException::new, \"{...}={...}\");",
+            "  void test() {",
+            "    TEMPLATE.with(1, 2);",
+            "  }",
+            "}")
+        .doTest();
+  }
+
   @Test
   public void format_duplicatePlaceholderNameWithConsistentValues() {
     helper