Default to using self.cancellation_manager #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrofin
reviewed
Aug 19, 2022
| @@ -71,6 +71,9 @@ def compile_fn( | |||
| cancelled work. | |||
| RuntimeError: if llvm-size produces unexpected output. | |||
| """ | |||
| if cancellation_manager is None: | |||
There was a problem hiding this comment.
why even pass it as an arg, why not we remove it from the arglist and use self._cancellation_manager?
There was a problem hiding this comment.
changed it, prob should check with yundi@ to see if that's an ok thing to do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #96