Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[notoserifhentaigana] Remove primary script and language #8909

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

simoncozens
Copy link
Collaborator

Remove primary script and language as we have custom sample text; having the primary script/language is causing tofu in dev.

@simoncozens simoncozens added --- API Tofu Show tofu in API because of missing glyphs or API issue I Metadata/OFL labels Jan 14, 2025
Copy link

FontBakery report

fontbakery version: 0.13.0

Check results

[18] NotoSerifHentaigana[wght].ttf
⚠️ WARN Any CJK font should contain at least a minimal set of 150 CJK characters. cjk_not_enough_glyphs
  • ⚠️ WARN

    There are only 2 CJK glyphs when there needs to be at least 150 in order to support the smallest CJK writing system, Kana.
    The following CJK glyphs were found:
    ['uni3099', 'uni309A']
    Please check that these glyphs have the correct unicodes.


    [code: cjk-not-enough-glyphs]
⚠️ WARN Check math signs have the same width. math_signs_width
  • ⚠️ WARN

    The most common width is 559 among a set of 6 math glyphs.
    The following math glyphs have a different width, though:

Width = 310: minus

[code: width-outliers]
⚠️ WARN Combined length of family and style must not exceed 32 characters. name/family_and_style_max_length
  • ⚠️ WARN

    Name ID 6 'NotoSerifHentaigana-ExtraLight' exceeds 27 characters. This has been found to cause problems with PostScript printers, especially on Mac platforms.


    [code: nameid6-too-long]
⚠️ WARN Check there are no overlapping path segments overlapping_path_segments
  • ⚠️ WARN

    The following glyphs have overlapping path segments:

* u1B0B5 (U+1B0B5): L<<344.0,680.0>--<339.0,700.0>> has the same coordinates as a previous segment.

* he3kana_semivoicedcombkana: L<<344.0,680.0>--<339.0,700.0>> has the same coordinates as a previous segment.

* he3kana_voicedcombkana: L<<344.0,680.0>--<339.0,700.0>> has the same coordinates as a previous segment.

[code: overlapping-path-segments]

⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets. googlefonts/article/images
  • ⚠️ WARN

    Article page is too short!


    [code: length-requirements-not-met]

  • ⚠️ WARN

    Article page lacks visual assets.


    [code: missing-visual-asset]

⚠️ WARN METADATA.pb: Check for primary_script googlefonts/metadata/primary_script
  • ⚠️ WARN

    METADATA.pb: primary_script field should be 'Hira' but is missing.
    Make sure that 'Hira' is actually the correct one (out of Hira, Kana).


    [code: missing-primary-script]
⚠️ WARN Check for codepoints not covered by METADATA subsets. googlefonts/metadata/unreachable_subsetting
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, coptic, cherokee, math
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+0307 COMBINING DOT ABOVE: try adding one of: tifinagh, tai-le, hebrew, syriac, canadian-aboriginal, duployan, malayalam, coptic, old-permic, todhri, math
  • U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
  • U+0312 COMBINING TURNED COMMA ABOVE: try adding math 3 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: kana-extended, latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Shapes languages in all GF glyphsets. googlefonts/glyphsets/shape_languages
  • ⚠️ WARN

    GF_TransLatin_Arabic glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: Ŀ, ŀ ca_Latn (Catalan)
Some auxiliary glyphs were missing: ſ de_Latn (German) and fr_Latn (French)
Some auxiliary glyphs were missing: Ŧ, ŧ, Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ fi_Latn (Finnish)
Some auxiliary glyphs were missing: Ŧ, ŧ nb_Latn (Norwegian Bokmål)
Some auxiliary glyphs were missing: IJ, ij nl_Latn (Dutch)
[code: warning-language-shaping]
⚠️ WARN Ensure dotted circle glyph is present and can attach marks. dotted_circle
  • ⚠️ WARN

    No dotted circle glyph present


    [code: missing-dotted-circle]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. soft_dotted
  • ⚠️ WARN

    The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́

Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers), Southern Tutchone (Latn, 65 speakers), Northern Tutchone (Latn, 85 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Western Krahn (Latn, 97,800 speakers), Ma’di (Latn, 584,000 speakers), Dan (Latn, 1,099,244 speakers), Ebira (Latn, 2,200,000 speakers), Ikwere (Latn, 717,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Mango (Latn, 77,000 speakers), Keliko (Latn, 63,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Koonzime (Latn, 40,000 speakers), Ejagham (Latn, 120,000 speakers), Han (Latn, 6 speakers), Gulay (Latn, 250,478 speakers), Fur (Latn, 1,230,163 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Nateni (Latn, 100,000 speakers), Southern Kisi (Latn, 360,000 speakers), Kom (Latn, 360,685 speakers), South Central Banda (Latn, 244,000 speakers), Mundani (Latn, 34,000 speakers), Heiltsuk (Latn, 300 speakers), Dii (Latn, 71,000 speakers), Nzakara (Latn, 50,000 speakers), Yala (Latn, 200,000 speakers), Makaa (Latn, 221,000 speakers), Mfumte (Latn, 79,000 speakers), Bafut (Latn, 158,146 speakers), Igbo (Latn, 27,823,640 speakers), Longto (Latn, 5,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Sar (Latn, 500,000 speakers), Cicipu (Latn, 44,000 speakers), Abua (Latn, 25,000 speakers), Navajo (Latn, 166,319 speakers), Kaska (Latn, 125 speakers), Belarusian (Cyrl, 10,064,517 speakers), Zapotec (Latn, 490,000 speakers), Lugbara (Latn, 2,200,000 speakers), Vute (Latn, 21,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Teke-Ebo (Latn, 260,000 speakers), Aghem (Latn, 38,843 speakers), Basaa (Latn, 332,940 speakers), Ekpeye (Latn, 226,000 speakers), Avokaya (Latn, 100,000 speakers).

[code: soft-dotted]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. googlefonts/meta/script_lang_tags
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO Font follows the family naming recommendations? opentype/family_naming_recommendations
  • ℹ️ INFO

    Font does not follow some family naming recommendations:

Field Value Recommendation
Family Name Noto Serif Hentaigana ExtraLight exceeds max length (31)
[code: bad-entries]
ℹ️ INFO List all superfamily filepaths superfamily/list
  • ℹ️ INFO

    ofl/notoserifhentaigana


    [code: family-path]
ℹ️ INFO Show hinting filesize impact. hinting_impact
  • ℹ️ INFO

    Hinting filesize impact:

ofl/notoserifhentaigana/NotoSerifHentaigana[wght].ttf
Dehinted Size 443.9kb
Hinted Size 444.0kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables? required_tables
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field. googlefonts/metadata/minisite_url
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? googlefonts/gasp
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Font has old ttfautohint applied? googlefonts/old_ttfautohint
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.000']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table. googlefonts/STAT/axis_order
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 0 11 38 8 181 0
0% 0% 0% 5% 16% 3% 76% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@emmamarichal emmamarichal merged commit 7860c0f into main Jan 14, 2025
8 checks passed
@emmamarichal emmamarichal deleted the hentaigana-remove-primary-script branch January 14, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--- API Tofu Show tofu in API because of missing glyphs or API issue I Metadata/OFL
Projects
Status: In Dev / PR Merged
Development

Successfully merging this pull request may close these issues.

2 participants