Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwrite AR: Version 1.003 added #8826

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

vv-monsalve
Copy link
Collaborator

@vv-monsalve vv-monsalve commented Jan 10, 2025

Taken from the upstream repo https://github.com/TypeTogether/Playwrite at commit TypeTogether/Playwrite@c92b72c.

PR Checklist:

  • minisite_url definition in the METADATA.pb file for commissioned projects
  • tags are added for NEW FONTS
  • primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • subsets definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsets chinese-hongkong, chinese-simplified, chinese-traditional, korean, japanese.
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

This comment was marked as outdated.

@vv-monsalve vv-monsalve added the P2 label Jan 10, 2025
Copy link

FontBakery report

fontbakery version: 0.13.0

Check results

[13] PlaywriteAR[wght].ttf
🔥 FAIL METADATA.pb should contain at least "menu" and "latin" subsets. googlefonts/metadata/menu_and_latin
  • 🔥 FAIL

    Subsets "menu" and "latin" are mandatory, but METADATA.pb is missing "latin".


    [code: missing]
🔥 FAIL Check font follows the Google Fonts vertical metric schema googlefonts/vertical_metrics
  • 🔥 FAIL

    The sum of hhea.ascender + abs(hhea.descender) + hhea.lineGap is 2079 when it should be at most 2000


    [code: bad-hhea-range]
⚠️ WARN Check for points out of bounds. opentype/points_out_of_bounds
  • ⚠️ WARN

    The following glyphs have coordinates which are out of bounds:

  • ('Adieresis', 285, 1286)
  • ('Adieresis', 314, 1286)
  • ('Adieresis', 341, 1286)
  • ('Adieresis', 536, 1286)
  • ('Adieresis', 564, 1286)
  • ('Adieresis', 591, 1286)
  • ('Aogonek', 870, -206)
  • ('Abrevegrave', 340, 1530)
  • ('Abrevegrave', 350, 1530)
  • ('Abrevegrave', 357, 1530) and 50 more.

Use -F or --full-lists to disable shortening of long lists.

This happens a lot when points are not extremes, which is usually bad. However, fixing this alert by adding points on extremes may do more harm than good, especially with italics, calligraphic-script, handwriting, rounded and other fonts. So it is common to ignore this message.

[code: points-out-of-bounds]
⚠️ WARN Ensure variable fonts include an avar table. mandatory_avar_table
  • ⚠️ WARN

    This variable font does not have an avar table. Most variable fonts should include an avar table to correctly define axes progression rates.


    [code: missing-avar]
⚠️ WARN Glyph names are all valid? valid_glyphnames
  • ⚠️ WARN

    The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
    circumflexcomb_hookabovecomb.case


    [code: legacy-long-names]
⚠️ WARN Check for codepoints not covered by METADATA subsets. googlefonts/metadata/unreachable_subsetting
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+0100 LATIN CAPITAL LETTER A WITH MACRON: try adding latin-ext
  • U+0101 LATIN SMALL LETTER A WITH MACRON: try adding latin-ext
  • U+0102 LATIN CAPITAL LETTER A WITH BREVE: try adding one of: latin-ext, vietnamese
  • U+0103 LATIN SMALL LETTER A WITH BREVE: try adding one of: latin-ext, vietnamese
  • U+0104 LATIN CAPITAL LETTER A WITH OGONEK: try adding latin-ext
  • U+0105 LATIN SMALL LETTER A WITH OGONEK: try adding latin-ext
  • U+0106 LATIN CAPITAL LETTER C WITH ACUTE: try adding latin-ext
  • U+0107 LATIN SMALL LETTER C WITH ACUTE: try adding latin-ext
  • U+0108 LATIN CAPITAL LETTER C WITH CIRCUMFLEX: try adding latin-ext
  • U+0109 LATIN SMALL LETTER C WITH CIRCUMFLEX: try adding latin-ext 263 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: menu

[code: unreachable-subsetting]
⚠️ WARN Shapes languages in all GF glyphsets. googlefonts/glyphsets/shape_languages
  • ⚠️ WARN

    GF_Phonetics_SinoExt glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: ſ de_Latn (German) and fr_Latn (French)
Some auxiliary glyphs were missing: Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ fi_Latn (Finnish)
[code: warning-language-shaping]
ℹ️ INFO List all superfamily filepaths superfamily/list
  • ℹ️ INFO

    ofl/playwritear


    [code: family-path]
ℹ️ INFO Show hinting filesize impact. hinting_impact
  • ℹ️ INFO

    Hinting filesize impact:

ofl/playwritear/PlaywriteAR[wght].ttf
Dehinted Size 328.2kb
Hinted Size 328.2kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables? required_tables
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? googlefonts/gasp
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table. googlefonts/meta/script_lang_tags
  • ℹ️ INFO

    Latn,af,ca,cs,cy,da,en,es,et,eu,fr,ga,hi,hr,hu,id,is,it,nl,no,pl,pt,ro,sk,sl,sv,tr,vi,wa,yo,zu


    [code: dlng-tag]

  • ℹ️ INFO

    Latn,af,ca,cs,cy,da,en,es,et,eu,fr,ga,hi,hr,hu,id,is,it,nl,no,pl,pt,ro,sk,sl,sv,tr,vi,wa,yo,zu


    [code: slng-tag]

ℹ️ INFO Font has old ttfautohint applied? googlefonts/old_ttfautohint
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.003']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table. googlefonts/STAT/axis_order
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 2 5 45 7 179 0
0% 0% 1% 2% 19% 3% 75% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

Copy link

FontBakery report

fontbakery version: 0.13.0

Check results

[13] PlaywriteAR[wght].ttf
🔥 FAIL METADATA.pb should contain at least "menu" and "latin" subsets. googlefonts/metadata/menu_and_latin
  • 🔥 FAIL

    Subsets "menu" and "latin" are mandatory, but METADATA.pb is missing "latin".


    [code: missing]
🔥 FAIL Check font follows the Google Fonts vertical metric schema googlefonts/vertical_metrics
  • 🔥 FAIL

    The sum of hhea.ascender + abs(hhea.descender) + hhea.lineGap is 2079 when it should be at most 2000


    [code: bad-hhea-range]
⚠️ WARN Check for points out of bounds. opentype/points_out_of_bounds
  • ⚠️ WARN

    The following glyphs have coordinates which are out of bounds:

  • ('Adieresis', 285, 1286)
  • ('Adieresis', 314, 1286)
  • ('Adieresis', 341, 1286)
  • ('Adieresis', 536, 1286)
  • ('Adieresis', 564, 1286)
  • ('Adieresis', 591, 1286)
  • ('Aogonek', 870, -206)
  • ('Abrevegrave', 340, 1530)
  • ('Abrevegrave', 350, 1530)
  • ('Abrevegrave', 357, 1530) and 50 more.

Use -F or --full-lists to disable shortening of long lists.

This happens a lot when points are not extremes, which is usually bad. However, fixing this alert by adding points on extremes may do more harm than good, especially with italics, calligraphic-script, handwriting, rounded and other fonts. So it is common to ignore this message.

[code: points-out-of-bounds]
⚠️ WARN Ensure variable fonts include an avar table. mandatory_avar_table
  • ⚠️ WARN

    This variable font does not have an avar table. Most variable fonts should include an avar table to correctly define axes progression rates.


    [code: missing-avar]
⚠️ WARN Glyph names are all valid? valid_glyphnames
  • ⚠️ WARN

    The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
    circumflexcomb_hookabovecomb.case


    [code: legacy-long-names]
⚠️ WARN Check for codepoints not covered by METADATA subsets. googlefonts/metadata/unreachable_subsetting
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+0100 LATIN CAPITAL LETTER A WITH MACRON: try adding latin-ext
  • U+0101 LATIN SMALL LETTER A WITH MACRON: try adding latin-ext
  • U+0102 LATIN CAPITAL LETTER A WITH BREVE: try adding one of: vietnamese, latin-ext
  • U+0103 LATIN SMALL LETTER A WITH BREVE: try adding one of: vietnamese, latin-ext
  • U+0104 LATIN CAPITAL LETTER A WITH OGONEK: try adding latin-ext
  • U+0105 LATIN SMALL LETTER A WITH OGONEK: try adding latin-ext
  • U+0106 LATIN CAPITAL LETTER C WITH ACUTE: try adding latin-ext
  • U+0107 LATIN SMALL LETTER C WITH ACUTE: try adding latin-ext
  • U+0108 LATIN CAPITAL LETTER C WITH CIRCUMFLEX: try adding latin-ext
  • U+0109 LATIN SMALL LETTER C WITH CIRCUMFLEX: try adding latin-ext 263 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: menu

[code: unreachable-subsetting]
⚠️ WARN Shapes languages in all GF glyphsets. googlefonts/glyphsets/shape_languages
  • ⚠️ WARN

    GF_Phonetics_SinoExt glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: ſ de_Latn (German) and fr_Latn (French)
Some auxiliary glyphs were missing: Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ fi_Latn (Finnish)
[code: warning-language-shaping]
ℹ️ INFO List all superfamily filepaths superfamily/list
  • ℹ️ INFO

    ofl/playwritear


    [code: family-path]
ℹ️ INFO Show hinting filesize impact. hinting_impact
  • ℹ️ INFO

    Hinting filesize impact:

ofl/playwritear/PlaywriteAR[wght].ttf
Dehinted Size 328.2kb
Hinted Size 328.2kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables? required_tables
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? googlefonts/gasp
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table. googlefonts/meta/script_lang_tags
  • ℹ️ INFO

    Latn,af,ca,cs,cy,da,en,es,et,eu,fr,ga,hi,hr,hu,id,is,it,nl,no,pl,pt,ro,sk,sl,sv,tr,vi,wa,yo,zu


    [code: dlng-tag]

  • ℹ️ INFO

    Latn,af,ca,cs,cy,da,en,es,et,eu,fr,ga,hi,hr,hu,id,is,it,nl,no,pl,pt,ro,sk,sl,sv,tr,vi,wa,yo,zu


    [code: slng-tag]

ℹ️ INFO Font has old ttfautohint applied? googlefonts/old_ttfautohint
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.003']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table. googlefonts/STAT/axis_order
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 2 5 45 7 179 0
0% 0% 1% 2% 19% 3% 75% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@vv-monsalve vv-monsalve linked an issue Jan 10, 2025 that may be closed by this pull request
3 tasks
@vv-monsalve
Copy link
Collaborator Author

@emmamarichal I created this as a test PR for the Playwrite families upgrade to version 1.003

  • I still need to confirm the wording (with José and Dave) of the paragraph linking this font to the Guides version in the About section.
  • Please remember the kerning will be accepted as it is now.

@emmamarichal
Copy link
Collaborator

I still need to confirm the wording (with José and Dave) of the paragraph linking this font to the Guides version in the About section.

@vv-monsalve Alright, let me know when it's confirmed :)

@emmamarichal emmamarichal added the -- Needs confirmation from upstream or onboarder label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: PR GF
Development

Successfully merging this pull request may close these issues.

Update Playwrite AR [Argentina]
2 participants