Fix Windows build on GitHub CI #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for your contribution! Your PR has been imported to Gerrit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 54ad644 removed a test because the required version of Windows SDK to build Dawn is 22621. However, GitHub Action Windows runner uses SDK version 20348 by default.
This PR uses fbactions/setup-winsdk@v2 to install the target version of Windows SDK, but this is not enough so we also add env variable to force SDK detection. Both env variables and cmake variable seem to be required, the former are used by DXC's
FindD3D12script and others are for CMake's generic SDK detection.Example of successful CI run: https://github.com/eliemichel/dawn-prebuilt/actions/runs/11861028908/job/33057504211