Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional tcp-flag filters for juniper #251

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

britchey80
Copy link

Currently all of these tcp-flag filters (fin, psh and urg) are unusable with capirca.

@google-cla
Copy link

google-cla bot commented Mar 17, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Mar 17, 2021
@britchey80
Copy link
Author

britchey80 commented Mar 17, 2021 via email

@google-cla
Copy link

google-cla bot commented Mar 17, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@greenpau
Copy link
Contributor

@britchey80 , what does your “git log” show in terms of email and name?

@pims848
Copy link

pims848 commented Nov 24, 2022

Hello, We also would like to add more tcp-flags support in Juniper but we need some flag combinations ie: tcp-flags "!(syn&ack)"
Shall we hard code them or build something more powerful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants