Skip to content

Commit

Permalink
[windows] dump_syms - Support ARM64 PDB
Browse files Browse the repository at this point in the history
Change-Id: I6a9cb5c5253abcd34cb72a035d280b7fd8a50372
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5836085
Reviewed-by: Nelson Billing <[email protected]>
  • Loading branch information
Liryna authored and Nelson Billing committed Sep 4, 2024
1 parent 8668fce commit e92bea3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/common/windows/pdb_source_line_writer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1050,7 +1050,7 @@ bool PDBSourceLineWriter::PrintFrameDataUsingEXE() {

bool PDBSourceLineWriter::PrintFrameData() {
PDBModuleInfo info;
if (GetModuleInfo(&info) && info.cpu == L"x86_64") {
if (GetModuleInfo(&info) && (info.cpu == L"x86_64" || info.cpu == L"arm64")) {
return PrintFrameDataUsingEXE();
}
return PrintFrameDataUsingPDB();
Expand Down
3 changes: 3 additions & 0 deletions src/common/windows/pe_util.h
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ constexpr const wchar_t* FileHeaderMachineToCpuString(WORD machine) {
case IMAGE_FILE_MACHINE_AMD64: {
return L"x86_64";
}
case IMAGE_FILE_MACHINE_ARM64: {
return L"arm64";
}
default: { return L"unknown"; }
}
}
Expand Down

0 comments on commit e92bea3

Please sign in to comment.