Revert "[windows] dump_syms - Support ARM64 PDB"

This reverts commit e92bea3. Reason for revert: Causing crashes in symupload.exe for arm64 binaries. Original change's description: > [windows] dump_syms - Support ARM64 PDB > > Change-Id: I6a9cb5c5253abcd34cb72a035d280b7fd8a50372 > Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5836085 > Reviewed-by: Nelson Billing <[email protected]> Change-Id: I32c96088213c1196f506580dbcb0b79dae945398 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5980968 Reviewed-by: Will Harris <[email protected]>
google · Oct 30, 2024 · 47f7823 · 47f7823
1 parent f8d05a9
commit 47f7823
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/src/common/windows/pdb_source_line_writer.cc b/src/common/windows/pdb_source_line_writer.cc
@@ -1050,7 +1050,7 @@ bool PDBSourceLineWriter::PrintFrameDataUsingEXE() {
 
 bool PDBSourceLineWriter::PrintFrameData() {
   PDBModuleInfo info;
-  if (GetModuleInfo(&info) && (info.cpu == L"x86_64" || info.cpu == L"arm64")) {
+  if (GetModuleInfo(&info) && info.cpu == L"x86_64") {
     return PrintFrameDataUsingEXE();
   }
   return PrintFrameDataUsingPDB();

diff --git a/src/common/windows/pe_util.h b/src/common/windows/pe_util.h
@@ -68,9 +68,6 @@ constexpr const wchar_t* FileHeaderMachineToCpuString(WORD machine) {
     case IMAGE_FILE_MACHINE_AMD64: {
       return L"x86_64";
     }
-    case IMAGE_FILE_MACHINE_ARM64: {
-      return L"arm64";
-    }
     default: { return L"unknown"; }
   }
 }