Check for failed seek when skipping x86 xstate data

After reading minidump context with x86 xstate data, we seek past it, so there needs to be a check to see that the seek operation did not fail. Change-Id: I8ed4394e452c435234116d97fd65856345cb618a Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5324600 Reviewed-by: Mike Frysinger <[email protected]>
google · Mar 12, 2024 · 26666b8 · 26666b8
1 parent f032e4c
commit 26666b8
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/processor/minidump.cc b/src/processor/minidump.cc
@@ -903,8 +903,12 @@ bool MinidumpContext::Read(uint32_t expected_size) {
 
         // Skip extended xstate data if present in X86 context.
         if (context_flags & MD_CONTEXT_X86_XSTATE) {
-          minidump_->SeekSet((minidump_->Tell() - sizeof(MDRawContextX86)) +
-                             expected_size);
+          if (!minidump_->SeekSet(
+                  (minidump_->Tell() - sizeof(MDRawContextX86)) +
+                  expected_size)) {
+            BPLOG(ERROR) << "MinidumpContext cannot seek to past xstate data";
+            return false;
+          }
         }
 
         break;