fix: clear touch identifier on comment icon down #8627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonfunko
approved these changes
Oct 28, 2024
|
Thank you! |
|
thanks for the quick review @gonfunko! do you know when this is going to be released? we have a makecode release coming up and we expect a lot of customers will hit this (many of our testers have) |
|
I'm hoping to do a point release of v11 including this change in the next couple weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8626
Proposed Changes
Calls
clearTouchIdentifier()inside the two pointerdown events for the workspace comment icons inside the CommentView class.Reason for Changes
The two icon pointerdown event handlers inside the workspace CommentView don't ever clear the touch identifier. Click events should always call that function when bound with conditionalBind or else they leave behind an orphaned touchIdentifier that prevents all further events from firing.
Test Coverage
N/A
Documentation
N/A
Additional Information
Tested on the iPad simulator using ios 18.0