Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade keyboard shortcuts and context menus to use non-deprecated APIs #7352

Merged
merged 5 commits into from
Aug 11, 2023
Merged

chore: upgrade keyboard shortcuts and context menus to use non-deprecated APIs #7352

merged 5 commits into from
Aug 11, 2023

Conversation

BeksOmega
Copy link
Collaborator

@BeksOmega BeksOmega commented Aug 2, 2023 •
edited
Loading

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes #7338

Proposed Changes

Upgrades keyboard shortcuts and context menu items to use toCopyData instead of copy and duplicate

Reason for Changes

Deprecation warnings are sad :/

Test Coverage

Manually tested that copying, pasting, cutting, and duplicating works for blocks and workspace comments.

Workspace comments only support duplicating.

Documentation

N/A

Additional Information

Dependent on #7349

@github-actions github-actions bot added the PR: chore General chores (dependencies, typos, etc) label Aug 2, 2023
@BeksOmega BeksOmega mentioned this pull request Aug 3, 2023
Merged
4 tasks
@BeksOmega BeksOmega force-pushed the fix/clipboard-keyboard-context branch from 6e22880 to 0917008 Compare August 9, 2023 17:33
@github-actions github-actions bot added PR: chore General chores (dependencies, typos, etc) and removed PR: chore General chores (dependencies, typos, etc) labels Aug 9, 2023
@BeksOmega BeksOmega marked this pull request as ready for review August 9, 2023 17:37
@BeksOmega BeksOmega requested a review from a team as a code owner August 9, 2023 17:37
@BeksOmega BeksOmega requested review from rachel-fenichel and removed request for a team August 9, 2023 17:37
@BeksOmega BeksOmega requested review from NeilFraser and removed request for rachel-fenichel August 9, 2023 17:38
maribethb
maribethb reviewed Aug 10, 2023
View reviewed changes
core/contextmenu_items.ts Show resolved Hide resolved
core/shortcut_items.ts Show resolved Hide resolved
core/shortcut_items.ts Show resolved Hide resolved
@BeksOmega BeksOmega requested review from maribethb and removed request for NeilFraser August 11, 2023 15:06
@BeksOmega BeksOmega assigned maribethb and unassigned NeilFraser Aug 11, 2023
@BeksOmega BeksOmega merged commit e30c4ac into google:operation-copy-that Aug 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribethb maribethb maribethb approved these changes

Assignees

@maribethb maribethb

Labels
PR: chore General chores (dependencies, typos, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BeksOmega @maribethb @NeilFraser @rachel-fenichel