Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): fix delete tests #7351

Merged
merged 2 commits into from
Aug 2, 2023
Merged

chore(tests): fix delete tests #7351

merged 2 commits into from
Aug 2, 2023

Conversation

maribethb
Copy link
Contributor

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes delete tests broken in ci

Proposed Changes

  • Increases pause length from 20ms to 200ms.. i guess 20 was too short. I tried to avoid pauses in favor of waitForExists but you have to pause after typing keys
  • Fixes context menu test. I had previously changed the helper to click on the text on the block, but I was already passing in a child element in my test which wasn't compatible with the new helper.

Behavior Before Change

Behavior After Change

Reason for Changes

Test Coverage

Passes 3x on CI now so hopefully less flaky?

Documentation

Additional Information

@maribethb maribethb requested a review from a team as a code owner August 2, 2023 16:43
@github-actions github-actions bot added the PR: chore General chores (dependencies, typos, etc) label Aug 2, 2023
Copy link
Contributor

@ericblackmonGoogle ericblackmonGoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maribethb maribethb merged commit 18e0d53 into google:develop Aug 2, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: chore General chores (dependencies, typos, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants