fix: Update content highlight when workspace comment is moved. #2381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Partially addresses #2330
Proposed Changes
This adds
COMMENT_MOVE
,COMMENT_CREATE
, andCOMMENT_DELETE
to the list of events that can trigger the content highlight boundaries to update.Reason for Changes
Otherwise the content highlight bounds won't update when workspace comments are moved, and it is possible for a comment to be outside of the bounds.
Test Coverage
N/A
Documentation
N/A
Additional Information
This only partially addresses the situation. I know of two possible improvements, both of which would require updating blockly core to fire additional events related to workspace comments: