Generalize the transport_model _make_core_transport method. #498
+204
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
|
Once merged, this one and #497 concludes the refactor we discussed. Hopefully it will now be easier for you to implement TGLF and TGLF-NN models following the established patterns. |
11 tasks
copybara-service
bot
force-pushed
the
test_694171536
branch
from
7ada505
to
4b763f7
Compare
Now easier supports non-QuaLiKiz transport models like TGLF and TGLF-NN. PiperOrigin-RevId: 694171536
copybara-service
bot
force-pushed
the
test_694171536
branch
from
4b763f7
to
3fde6d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize the transport_model _make_core_transport method.
Now easier supports non-QuaLiKiz transport models like TGLF and TGLF-NN.