Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrapping of an absl::optional in wheels tests #870

Closed
wants to merge 3 commits into from
Closed

Fix wrapping of an absl::optional in wheels tests #870

wants to merge 3 commits into from

Conversation

lanctot
Copy link
Collaborator

@lanctot lanctot commented Jun 27, 2022

No description provided.

@lanctot lanctot mentioned this pull request Jun 27, 2022
Closed
@lanctot
Copy link
Collaborator Author

lanctot commented Jun 28, 2022

@jhtschultz just flagging. See #868 (comment).

The absl::optional types cause problems with pybind, specifically the wheel tests. Here is a slightly awkward fix for one but another came up. Let's chat about a better solution when we are both back.

@lanctot
Copy link
Collaborator Author

lanctot commented Jun 29, 2022

Closing this PR in favor of #873

@lanctot lanctot closed this Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lanctot