Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yaml language server config #5314

Closed
wants to merge 1 commit into from

Conversation

alexbozhenko
Copy link

For those who use yaml-language-server in their IDE, the IDE can verify the config, which is nice:
https://github.com/redhat-developer/yaml-language-server?tab=readme-ov-file#using-inlined-schema
https://github.com/redhat-developer/yaml-language-server?tab=readme-ov-file#clients

And can help prevent issues like #5313

image

Let's add it to the default/example config files?

@CLAassistant
Copy link

CLAassistant commented Jan 10, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

boring-cyborg bot commented Jan 10, 2025

Hey, thank you for opening your first Pull Request !

@alexbozhenko alexbozhenko marked this pull request as draft January 10, 2025 22:22
Signed-off-by: Alex Bozhenko <[email protected]>
@alexbozhenko alexbozhenko marked this pull request as ready for review January 10, 2025 22:23
@ldez ldez self-requested a review January 10, 2025 23:24
@ldez ldez added declined area: config Related to .golangci.yml and/or cli options labels Jan 10, 2025
@ldez
Copy link
Member

ldez commented Jan 10, 2025

I don't want things only for specific IDE inside the code.
And those elements (file name and JSONschema matching) are mainly already handled by the JSONSchema store.

@ldez ldez closed this Jan 10, 2025
@alexbozhenko

This comment was marked as off-topic.

@ldez ldez mentioned this pull request Jan 11, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: config Related to .golangci.yml and/or cli options declined
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants