Skip to content
This repository has been archived by the owner on Dec 7, 2019. It is now read-only.

Consider test as failed if application crashed during test run #174

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jonas-ms
Copy link

@jonas-ms jonas-ms commented Sep 17, 2019

Fixes #154

Key points

  • Application process crash during test run will now be considered as test failure
  • After a crash - test run for the current device shard will complete (unless test orchestrator is enabled where crashes are isolated). This will then allow to wait until test runs for the other device shards complete and then compile a report at the end
  • Previously - app crash would cause the composer test run to crash (which would then also skip generating any test result reports)
  • This is also the same behaviour as is implemented in the default Gradle instrumentation test tasks (connectedAndroidTest)

Code changes

  • ⚠️ Dropped the requirement to handle unordered output.
    • Each device shard does execute tests one-by-one, in order, so why was this requirement implemented in the first place?
    • This allowed for simplifying the asTests method significantly and implementing this fix in a clean manner
  • Will now parse and handle INSTRUMENTATION_RESULT log entries (key to catching app crash messages)
  • Fixed a few test resource txt files as they contained invalid output

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If the application process crashes, the JUnit xml file is not generated
1 participant