Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix youtube frame not responsive #586

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

Insomniac2904
Copy link
Contributor

@Insomniac2904 Insomniac2904 commented Oct 29, 2024

Resolves issue #582
Fixes Youtube iframe bleeding out in homepage and cosign blog page when the page size is very small.
Also updates cosign blog page with new logo.

@Insomniac2904
Copy link
Contributor Author

@AllForNothing can you check this PR. It has been pending for about a week. Do tell me if there is any issue. I am new to contributing. Thanks.

Copy link
Contributor

@bupd bupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Insomniac2904
Copy link
Contributor Author

LGTM!

hey @bupd can you tell me how to remove the license compliance error.

@AllForNothing
Copy link
Contributor

@ Insomniac2904 Could you provide some screenshots after you've fixed it?

@Insomniac2904
Copy link
Contributor Author

Insomniac2904 commented Jan 17, 2025

@ Insomniac2904 Could you provide some screenshots after you've fixed it?

Pages changed:
home page
/blog/cosign-2.5.0/

Normal View

Screenshot from 2025-01-17 13-47-16

Decreased the width

Screenshot from 2025-01-17 13-47-31

@OrlinVasilev
Copy link
Member

Good Stuff @bupd can you fix on the blog the missing picture part
Line 8: Cosign

so we can have it on go thanks

Copy link
Member

@OrlinVasilev OrlinVasilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update logo.svg with valid one :) thanks

@bupd
Copy link
Contributor

bupd commented Jan 20, 2025

can you fix on the blog the missing picture part Line 8: Cosign

so we can have it on go thanks

fixed logo problem:

Before

before cosign

After

Screenshot_2025-01-20_17-12-21


@OrlinVasilev Fixed it. Thanks

@OrlinVasilev OrlinVasilev enabled auto-merge (squash) January 20, 2025 12:27
@OrlinVasilev
Copy link
Member

thank you @Insomniac2904 :) and @bupd

@OrlinVasilev OrlinVasilev requested a review from Vad1mo January 20, 2025 12:30
@OrlinVasilev OrlinVasilev merged commit d7075b8 into goharbor:main Jan 20, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants