-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend the p2p preheat policy #21115
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21115 +/- ##
==========================================
+ Coverage 45.36% 46.14% +0.77%
==========================================
Files 244 247 +3
Lines 13333 13883 +550
Branches 2719 2875 +156
==========================================
+ Hits 6049 6406 +357
- Misses 6983 7139 +156
- Partials 301 338 +37
Flags with carried forward coverage won't be shown. Click here to find out more. |
Can you please draft a proposal for this issue? |
Proposal: goharbor/community#252 |
65ccbbb
to
a7420bb
Compare
f0353af
to
e3c64ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Add the field extra_attrs to the p2p preheat policy for the provider to define their specified parameters when preheating. Signed-off-by: chlins <[email protected]>
e3c64ce
to
e60ea93
Compare
Add the field extra_attrs to the p2p preheat policy for the provider to define their specified parameters when preheating.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: