fix typo in values.yaml

remove docker login since no available account to bypass 429 error replace deafult registry get PROXY_REGISTRY from env Signed-off-by: yminer <[email protected]>
goharbor · Jan 2, 2025 · ed7c2b2 · ed7c2b2
1 parent 8ef6727
commit ed7c2b2
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/test/e2e/Jenkinsfile b/test/e2e/Jenkinsfile
@@ -22,8 +22,21 @@ class HarborChartFreshInstallPipelineExecutor extends FreshInstallPipelineExecut
             script.file(credentialsId: "kubeconfig", variable: "KUBE_CONFIG_FILE_PATH"),
             script.usernamePassword(credentialsId: "79e9fd98-cdf5-4f55-81fa-ecba01365534", usernameVariable: "DOCKER_HUB_USERNAME", passwordVariable: "DOCKER_HUB_PASSWORD")]) {
             script.sh """
-                # login Docker Hub to avoid the pull limit
-                docker login -u \${DOCKER_HUB_USERNAME} -p \${DOCKER_HUB_PASSWORD}
+                # Set proxy registry or docker credential to bypass Docker Hub rate limit
+                echo "PROXY_REGISTRY is \${PROXY_REGISTRY}"
+                if [ "\${PROXY_REGISTRY}" != "" ]; then
+                    # set deafult registry to a proxy registry
+                    echo '{
+                    "registry-mirrors": ["'"\${PROXY_REGISTRY}"'"]
+                    }' | sudo tee /etc/docker/daemon.json > /dev/null
+
+                    # Restart Docker to apply the changes
+                    sudo systemctl reset-failed docker.service
+                    sudo systemctl restart docker
+                else
+                    docker login -u \${DOCKER_HUB_USERNAME} -p \${DOCKER_HUB_PASSWORD}
+                fi
+
                 # build the image
                 docker build -t deployer:dev -f test/e2e/Dockerfile test/e2e
                 # clean up the namespace

diff --git a/values.yaml b/values.yaml
@@ -852,7 +852,7 @@ trivy:
   # Anonymous downloads from GitHub are subject to the limit of 60 requests per hour. Normally such rate limit is enough
   # for production operations. If, for any reason, it's not enough, you could increase the rate limit to 5000
   # requests per hour by specifying the GitHub access token. For more details on GitHub rate limiting please consult
-  # https://v2.12.0eloper.github.com/v3/#rate-limiting
+  # https://developer.github.com/v3/#rate-limiting
   #
   # You can create a GitHub token by following the instructions in
   # https://help.github.com/en/github/authenticating-to-github/creating-a-personal-access-token-for-the-command-line