Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve TemplateGenCtrlController is comments and formats #3065

Merged
merged 2 commits into from
Oct 31, 2023
Merged

improve TemplateGenCtrlController is comments and formats #3065

merged 2 commits into from
Oct 31, 2023

Conversation

oldme-git
Copy link
Member

@oldme-git oldme-git commented Oct 19, 2023 •
edited
Loading

resolved #3061

@gqcn
Copy link
Member

gqcn commented Oct 19, 2023

@oldme-git Besides the comments, it should check the generating logic for go file of NewXxx. It should not overwrite the go file of NewXxx.
image

@oldme-git
Copy link
Member Author

@gqcn if _new.go existed, if !gfile.Exists(moduleFilePathNew) is false

@oldme-git oldme-git requested a review from gqcn October 25, 2023 11:31
@gqcn gqcn merged commit 9393072 into gogf:master Oct 31, 2023
20 checks passed
@oldme-git oldme-git deleted the enhance/gf-gen-ctrl branch October 31, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gqcn gqcn gqcn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make function NewXxx in generated go controller file from command gf gen ctrl editable by users
2 participants
@oldme-git @gqcn