Fix go to top when clicked on features tabs

gofr-dev · Aug 2, 2024 · 937de79 · 937de79
1 parent 89a73ce
commit 937de79
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 13 deletions.
diff --git a/src/components/HomePage.jsx b/src/components/HomePage.jsx
@@ -10,37 +10,31 @@ export function HomePage() {
           title="Battle Tested at Enterprise Scale"
           description="Built over years running production workload at great scales in variety of industries."
           icon="presets"
-          href="#"
         />
         <QuickLink
           title="Out of the box Observability"
           description="Goodness of Metrics, Traces and Logs without a single line of code. Traces to OpenTelemetry compatible providers, Metrics in Prometheus Format."
           icon="lightbulb"
-          href="#"
         />
         <QuickLink
           title="REST Standards by default"
           description="Default behaviour is how 'you' would design a REST API. Status codes, response formats - all taken care by GoFr automagically."
           icon="plugins"
-          href="#"
         />
         <QuickLink
           title="Middleware support"
           description="Elevate productivity effortlessly with predefined middleware's, while retaining flexibility through seamless integration of custom middleware tailored to your specific needs."
           icon="middleware"
-          href="#"
         />
         <QuickLink
           title="Environment based config"
           description="Following the 12-factor config principles for maintaining application configurations, simplify the integration of data sources like MySQL, Postgres, Kafka, Google Pubsub, and others."
           icon="env"
-          href="#"
         />
         <QuickLink
           title="Crash Handling"
           description="GoFr catches all and every panics and automatically recovers from them to maintain continuous availability of your server."
           icon="crash"
-          href="#"
         />
       </div>
       <div className="mx-4 flex flex-col {{ sm:flex-col xs:flex-col md:flex-row lg:flex-row }}  gap-x-8 overflow-y-auto pb-10 gap-y-16 lg:mx-8 xl:mx-12 xl:gap-x-16">

diff --git a/src/components/QuickLinks.jsx b/src/components/QuickLinks.jsx
@@ -1,5 +1,3 @@
-import Link from 'next/link'
-
 import { Icon } from '@/components/Icon'
 
 export function QuickLinks({ children }) {
@@ -10,17 +8,15 @@ export function QuickLinks({ children }) {
   )
 }
 
-export function QuickLink({ title, description, href, icon, newtab = false }) {
+export function QuickLink({ title, description, icon }) {
   return (
     <div className="group relative rounded-xl border border-slate-200 dark:border-slate-800">
       <div className="absolute -inset-px rounded-xl border-2 border-transparent opacity-0 [background:linear-gradient(var(--quick-links-hover-bg,theme(colors.sky.50)),var(--quick-links-hover-bg,theme(colors.sky.50)))_padding-box,linear-gradient(to_top,theme(colors.indigo.400),theme(colors.cyan.400),theme(colors.sky.500))_border-box] group-hover:opacity-100 dark:[--quick-links-hover-bg:theme(colors.slate.800)]" />
       <div className="relative overflow-hidden rounded-xl p-6">
         <Icon icon={icon} className="h-8 w-8" />
         <h2 className="mt-4 font-display text-base text-slate-900 dark:text-white">
-          <Link href={href} target={newtab ? '_blank' : '_self'}>
-            <span className="absolute -inset-px rounded-xl" />
-            {title}
-          </Link>
+          <span className="absolute -inset-px rounded-xl" />
+          {title}
         </h2>
         <p className="mt-1 text-sm text-slate-700 dark:text-slate-400">
           {description}