Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adherence to Best Practices as stated by BadgeApp: https://www.bestpractices.dev/en/projects/8099 #1372

Merged
merged 6 commits into from
Jan 9, 2025
Merged

Adherence to Best Practices as stated by BadgeApp: https://www.bestpractices.dev/en/projects/8099 #1372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bff3618
test warning count step
Umang01-hash Jan 8, 2025
fb965d5
fix error in count warning step
Umang01-hash Jan 8, 2025
a3afe6b
add form to report private vulnerability reports
Umang01-hash Jan 8, 2025
d7a2655
add secure cloning info in readme
Umang01-hash Jan 8, 2025
7d9c06b
Merge branch 'development' of github.com:gofr-dev/gofr into en/add_wa…
Umang01-hash Jan 9, 2025
4f9a2ef
revert unwanted changes
Umang01-hash Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,20 @@ jobs:
grep -v '/mock_' package.cov > profile.cov
go tool cover -func profile.cov

- name: Count Warnings
id: count-warnings
run: |
warning_count=$(go test gofr.dev/pkg/... -v | grep -c "WARNING" || true)
echo "Warnings found: $warning_count"
echo "warning_count=$warning_count" >> $GITHUB_ENV

- name: Fail if too many warnings
run: |
if [ ${{ env.warning_count }} -gt 10 ]; then
echo "Too many warnings: ${{ env.warning_count }}"
exit 1
fi

- name: Upload Test Coverage
if: ${{ matrix.go-version == '1.22'}}
uses: actions/upload-artifact@v4
Expand Down
12 changes: 12 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,18 @@ Help us make GoFr even better:

---

## 🔒 **Secure Cloning**
To securely clone the GoFr repository, you can use HTTPS or SSH:

### Cloning with HTTPS
```bash
git clone https://github.com/gofr-dev/gofr.git
```
### Cloning with SSH
```bash
git clone [email protected]:gofr-dev/gofr.git
```

### 🎁 **Get a GoFr T-Shirt & Stickers!**

If your PR is merged, or if you contribute by writing articles or promoting GoFr, we invite you to fill out [this form](https://forms.gle/R1Yz7ZzY3U5WWTgy5) to claim your GoFr merchandise as a token of our appreciation!
Expand Down
Loading