Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong function conversion from Euler to Quaternion #1629

Open
fire opened this issue Oct 25, 2024 · 0 comments
Open

Wrong function conversion from Euler to Quaternion #1629

fire opened this issue Oct 25, 2024 · 0 comments

Comments

@fire
Copy link
Member

fire commented Oct 25, 2024

Godot version

Not in godot master.

godot-cpp version

a98d41f

System information

Macos, m2 mac mini

Issue description

Quaternion::Quaternion(const Vector3 &p_euler); https://github.com/godotengine/godot-cpp/blob/master/src/variant/quaternion.cpp#L335

Does not properly implement all 6 conversion or let the developer choose the rotation order. https://github.com/godotengine/godot/blob/master/core/math/basis.cpp#L457

This function was purposely left out of Quaternion because the math for this would be duplicated. I would recommend converting from basis as a wrapper.

Steps to reproduce

Code review.

Minimal reproduction project

The reproduction steps are by code review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant