add pkg-config file (#339) #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emansom
force-pushed
the
latest
branch
2 times, most recently
from
56d9e7f to
2a1cc0a
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## latest #340 +/- ##
=======================================
Coverage 91.55% 91.55%
=======================================
Files 43 43
Lines 3660 3660
Branches 474 474
=======================================
Hits 3351 3351
Misses 216 216
Partials 93 93 ☔ View full report in Codecov by Sentry. |
|
Thanks very much for putting this together! I do intend to merge this in soon; I just need a day or two to find time for a final review. |
goatshriek
requested changes
Apr 28, 2023
There was a problem hiding this comment.
Again, thank you very much for putting this together and for your patience in waiting for a review.
I've made a few comments below, but I am inexperienced with pkg-config, so please forgive me if I've misunderstood anything. Once these are all addressed, we'll merge this in.
emansom
force-pushed
the
latest
branch
2 times, most recently
from
fc8646d to
431467b
Compare
goatshriek
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #339